Adding QuotarRP network RP examples#15413
Adding QuotarRP network RP examples#15413rahuls-microsoft wants to merge 62 commits intoAzure:masterfrom rahuls-microsoft:master
Conversation
…pportTicketAction. 2. Removing state=enabledForPreview. 3. Updating Example.
…20-10-01-preview/reservations.json, which matches the previous SDK release. 2. Documentation changes.
…ONE quota request, so changing quotas to quota.
This reverts commit 8f58d34.
|
Hi, @rahuls-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Quotas_Request_ForNetwork Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L90 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L520 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L565 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L715 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L797 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L929 |
|
| Based on the response model schema, operation 'QuotaResourceProviders_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L358 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isQuotaApplicable Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L560 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isQuotaApplicable Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L924 |
|
| 'OperationList' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L429 |
|
| 'OperationResponse' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L444 |
|
| 'OperationDisplay' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L458 |
|
| 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L432 |
|
| 'name' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L447 |
|
| 'display' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L450 |
|
| 'origin' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L453 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Quotas_Request_ForCompute Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L90 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌ModelValidation: 3 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: provisioningState Url: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L500 JsonUrl: preview/2021-03-15-preview/examples/putNetworkOneSkuQuotaRequest.json#L22 |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: provisioningState Url: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L500 JsonUrl: preview/2021-03-15-preview/examples/patchNetworkOneSkuQuotaRequest.json#L22 |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: properties Url: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L846 JsonUrl: preview/2021-03-15-preview/examples/getQuotaRequestsHistory.json |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"quota/resource-manager/readme.md",
"tag":"package-2021-03-15-preview",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"quota/resource-manager/readme.md",
"tag":"package-2021-03-15-preview",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"quota/resource-manager/readme.md",
"tag":"package-2021-03-15-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @rahuls-microsoft, Your PR has some issues. Please fix the CI sequentially by following the order of
|
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.